Fix for issue #303 #444
Fix for issue #303 #444
Conversation
|
@jameskirsop can you check the failed travis jobs? |
| @@ -233,9 +233,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| if "${::python::version}" =~ /^python3/ { #lint:ignore:only_variable_string | |||
| if "${python::version}" =~ /^python3/ and ($facts['os']['family'] == 'RedHat') and (versioncmp($facts['os']['release']['major'], '7') >= 0) { #lint:ignore:only_variable_string | |||
There was a problem hiding this comment.
Does this not work with just:
if $python::version, which would fix the lint error and also avoid needing to ignore the lint error?
| $pip_category = undef | ||
| $pip_package = 'python3-pip' | ||
| $pip_package = 'python34-pip' |
There was a problem hiding this comment.
Wouldn’t this break later versions of python 3?
There was a problem hiding this comment.
@danquack, possibly - but given this module doesn't work at all with CentOS, this PR is intended as a step towards bridging the gap. I'd suggest that if the repo maintainers move to a different naming convention, we would adapt the install manifest to reflect that - and possibly be more inclusive of other available python/pip combinations.
There's currently no pip available for higher versions of python from repos, as far as I can tell, and using the python34 one with python36 (manually) seems to work OK.
Pull Request (PR) description
Adds better python34 pip support on CentOS7
This Pull Request (PR) fixes the following issues
Fixes #303
Fixes #442